- 🇮🇳India riddhi.addweb
I have applied the "coding-standards-3143545-5" patch cleanly but still, there are some errors.
Please check the screenshot for the same.FILE: /var/www/html/web/Drupal_9.5/web/modules/custom/pbf-3143545/tests/src/Functional/PbfAccessWithFormWidgetValueTest.php ------------------------------------------------------------------------------------------------------------------------------------------ FOUND 0 ERRORS AND 14 WARNINGS AFFECTING 14 LINES ------------------------------------------------------------------------------------------------------------------------------------------ 60 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 78 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 108 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 115 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 124 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 162 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 163 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 170 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 179 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 249 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 250 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 251 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 258 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 267 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead ------------------------------------------------------------------------------------------------------------------------------------------ FILE: /var/www/html/web/Drupal_9.5/web/modules/custom/pbf-3143545/tests/src/Functional/PbfAccessByRoleTest.php ----------------------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ----------------------------------------------------------------------------------------------------------------------------------------- 77 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead ----------------------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/web/Drupal_9.5/web/modules/custom/pbf-3143545/tests/src/Functional/PbfAccessWithSynchronizationTest.php ------------------------------------------------------------------------------------------------------------------------------------------ FOUND 1 ERROR AND 2 WARNINGS AFFECTING 3 LINES ------------------------------------------------------------------------------------------------------------------------------------------ 26 | ERROR | Class property $group_fieldname should use lowerCamel naming without underscores 122 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 172 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead ------------------------------------------------------------------------------------------------------------------------------------------ FILE: /var/www/html/web/Drupal_9.5/web/modules/custom/pbf-3143545/tests/src/Functional/PbfAccessByTermRefTest.php ----------------------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ----------------------------------------------------------------------------------------------------------------------------------------- 76 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead ----------------------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/web/Drupal_9.5/web/modules/custom/pbf-3143545/tests/src/Functional/PbfBaseTest.php ----------------------------------------------------------------------------------------------------------------------------------------- FOUND 3 ERRORS AND 1 WARNING AFFECTING 4 LINES ----------------------------------------------------------------------------------------------------------------------------------------- 7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Entity\Entity\EntityFormDisplay. 238 | WARNING | [ ] Line exceeds 80 characters; contains 82 characters 334 | ERROR | [ ] Arguments with default values must be at the end of the argument list 373 | ERROR | [ ] Arguments with default values must be at the end of the argument list ----------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/web/Drupal_9.5/web/modules/custom/pbf-3143545/tests/src/Functional/PbfAccessByUserDirectTest.php ----------------------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ----------------------------------------------------------------------------------------------------------------------------------------- 96 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead ----------------------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/web/Drupal_9.5/web/modules/custom/pbf-3143545/tests/src/Functional/PbfAccessByNodeRefTest.php ----------------------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ----------------------------------------------------------------------------------------------------------------------------------------- 73 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead ----------------------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/web/Drupal_9.5/web/modules/custom/pbf-3143545/tests/src/Functional/PbfAccessByUserRefTest.php ----------------------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ----------------------------------------------------------------------------------------------------------------------------------------- 92 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead ----------------------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/web/Drupal_9.5/web/modules/custom/pbf-3143545/src/Plugin/Field/FieldWidget/PbfFieldWidget.php -------------------------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 2 ERRORS AND 2 WARNINGS AFFECTING 4 LINES -------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Field\Plugin\Field\FieldWidget\EntityReferenceAutocompleteWidget. 41 | WARNING | [ ] Unused variable $grant_global. 46 | ERROR | [x] Use null coalesce operator instead of ternary operator. 113 | WARNING | [ ] Unused variable $field_definition. -------------------------------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/web/Drupal_9.5/web/modules/custom/pbf-3143545/src/Plugin/Field/FieldType/Pbf.php ------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------------------------- 10 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Field\Plugin\Field\FieldType\EntityReferenceItem. ------------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/web/Drupal_9.5/web/modules/custom/pbf-3143545/src/PbfSynchronize.php -------------------------------------------------------------------------------------------------------------------------------- FOUND 7 ERRORS AND 3 WARNINGS AFFECTING 10 LINES -------------------------------------------------------------------------------------------------------------------------------- 8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Entity\EntityInterface. 16 | WARNING | [ ] The class short comment should describe what the class does and not simply repeat the class name 43 | ERROR | [ ] Missing parameter comment 44 | ERROR | [ ] Missing parameter comment 45 | ERROR | [ ] Missing parameter comment 68 | WARNING | [ ] Unused variable $field_name. 126 | ERROR | [ ] Return type "mixed string|bool" must not contain spaces 139 | ERROR | [ ] Return type "mixed string|bool" must not contain spaces 226 | ERROR | [x] Use null coalesce operator instead of ternary operator. 230 | WARNING | [ ] Unused variable $added. -------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/web/Drupal_9.5/web/modules/custom/pbf-3143545/pbf.module ------------------------------------------------------------------------------------------------------------------------------ FOUND 2 ERRORS AND 2 WARNINGS AFFECTING 4 LINES ------------------------------------------------------------------------------------------------------------------------------ 11 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\field\FieldConfigInterface. 17 | WARNING | [ ] Global constants should not be used, move it to a class or interface 18 | WARNING | [ ] Global constants should not be used, move it to a class or interface 55 | ERROR | [ ] Unnecessarily gendered language in a comment ------------------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------