- last update
about 1 year ago Composer require failure - 🇮🇳India vipin.j
Re-rolled patch #11 with failing test case fixes and improvements.
- last update
about 1 year ago 117 pass, 12 fail - last update
11 months ago 136 pass, 6 fail The last submitted patch, 15: add_Shipping_method_with_combination_of_flat_rate__Flat_rate_per_item-3135404-15.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.Hi, vipin.j , can the patch be included in the next version release? I am not technical and not sure how to apply the patch every time when a new version is released. Thank you!
- 🇮🇳India vipin.j
@sdsc, I'm not the maintainer of Commerce Shipping but just a Drupal community contributor. including the patch in releases is totally in module maintainer's choice.
Yeah, but you can use Composer Patches plugin to update your code with recent patches available to issues queues.
- 🇮🇳India vipin.j
#14 and #15 patches were badly edited for test case requirement for plugin "Flat Rate + Per Item" which cause testbot failure.
here is the updated patch with a separate test case for "Flat Rate + Per Item". - last update
11 months ago 151 pass - Status changed to Needs review
11 months ago 1:45pm 11 January 2024 Hi, @vipin.j,
I applied the lates patch today, but everything appears the same. Did I do any thing wrong?
What I did:
1. in composer.json file, added the following under extra:
"enable-patching": true,
"patches": {
"drupal/core": {
"Combined shipping method": " https://www.drupal.org/files/issues/2024-01-11/flatrate_plus_per_item-31... → "
}
},
2. removed composer.lock file
3. run "composer install"
4. cleared cache on site
5. add new shipping method at: /admin/commerce/shipping-methods/addNothing different from before. Cannot see anywhere with combined shipping elements.
I tried commerce_shipping 2.x - 2.8 as well as 8.x-2.x-dev, the same, no difference than before. But I do too some conflicting information in composer.lock file, not sure whether it matters.:
"conflict": {
"drupal/commerce_shipping": "<2.1",
"drupal/physical": "<1.3"
},Appreciate any advice!
I found out what I did wrong, it should be "drupal/commerce_shipping". Now it works perfectly!!!
Thank you!!