Add confirmation for disruptive Drush commands?

Created on 10 May 2020, over 4 years ago
Updated 26 August 2024, 4 months ago

Drush commands like disabling indexes, clearing them or maybe also rebuilding their tracker (for large sites) have the potential to cause a lot of havoc on a site, if executed accidentally. Should we maybe add a confirmation dialog (i.e., user has to press y to continue) for them?
If so: Can we just do that, or is the chance too large that this will break people’s Drush scripts? (I guess good practice is to add -y to Drush calls in scripts anyways, but surely it’s still missing a lot of times.)

Feature request
Status

Active

Version

1.0

Component

Drush / Rules

Created by

🇦🇹Austria drunken monkey Vienna, Austria

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • 🇺🇸United States tr Cascadia

    If you want to add this feature I can write the code - I'm doing a lot of Drush work recently.
    Just list the commands you think should have a confirm dialog and I'll create a MR for it.

  • 🇦🇹Austria drunken monkey Vienna, Austria

    Thanks for the offer, very kind of you!
    At this point I’m just not sure I even want to make that change – would it help more, or be disruptive itself? As I haven’t really had people complain about this, as far as I remember, I’m currently leaning more toward the latter and closing this as “won’t fix”, but I’ve asked for feedback via Slack.

  • Status changed to Closed: won't fix 15 days ago
  • 🇦🇹Austria drunken monkey Vienna, Austria

    Not much support for this, so let’s just close and focus our efforts elsewhere.

Production build 0.71.5 2024