halt-on-fail option not respected during PHPCS

Created on 6 May 2020, over 4 years ago
Updated 17 January 2023, almost 2 years ago

Problem/Motivation

When a test run includes halt-on-fail: true in the build's assessment steps and there are violations it should:
- Mark the build as a failure
- Set the issue to Needs Work

This is currently not working as expected. For example in #3134162: Fix coding standards violations β†’ , the project was configured with:

phpcs:
  halt-on-fail: true

This causes PHPCS to exit with a status code of 2 but the build is still marked as "successful" and the build label is gray instead of red.

Proposed resolution

Fix Drupal CI so build assessment failures with halt-on-fail: true cause the job to fail.

Remaining tasks

TBD

User interface changes

Build assessment failures with halt-on-fail: true are treated the same as test failures.

API changes

None

Data model changes

None

Release notes snippet

TBD

πŸ› Bug report
Status

Active

Component

Testrunner Codebase

Created by

πŸ‡ΊπŸ‡ΈUnited States bobbygryzynger United States

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

No activities found.

Production build 0.71.5 2024