No information for external redirects

Created on 5 May 2020, over 4 years ago
Updated 31 January 2024, 8 months ago

When a redirect is setup to point to an external URL the decoupled router does not send the information about the redirect in the response. It only provides redirect information when the redirect is internal.

The module should provide the redirect element in the response when an external redirect is available.

πŸ› Bug report
Status

Needs review

Version

2.0

Component

Code

Created by

πŸ‡¬πŸ‡§United Kingdom johnennew

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Open in Jenkins β†’ Open on Drupal.org β†’
    Core: 10.1.4 + Environment: PHP 8.1 & MariaDB 10.3.22
    last update 11 months ago
    4 pass
  • πŸ‡―πŸ‡΄Jordan Ahmad Alyasaki

    The problem happened again to me, it's fixed with Patch Number 3, we need to first check if the URL is external. There's no need to send an external path to the Route service, For example, "mysite.com/media/news" would redirect to "example.com/news" if there's a route for "/news" in Drupal the Route service will redirect users to the same domain, ignoring the external path, That's why it's crucial to check if the path is external first. If it's not external, we can then send it to the route match. If there's no resource, just return a 404 status code.

  • Open in Jenkins β†’ Open on Drupal.org β†’
    Core: 10.2.1 + Environment: PHP 8.1 & MariaDB 10.3.22
    last update 8 months ago
    4 pass
  • πŸ‡ΊπŸ‡ΈUnited States jeffschuler Boulder, Colorado

    Keep the return after finding an external URL, otherwise the path will continue to be parsed and (depending on the structure of the URL) not always end up including the $redirects_trace (from, to, and status) information.

    Reverted back to the original comment because I believe it's more informative and correct than what it was recently changed to.

Production build 0.71.5 2024