- 🇦🇺Australia acbramley
I think this would be the perfect time to introduce some tests for the module since this is a fairly big change.
Returning AccessResult::forbidden() means that no other module can have a say over access due to forbidden overriding all other access results. This module should be returning neutral instead.
Use AccessResult::allowedIfHasPermission in block_content_permissions_block_content_type_access and block_content_permissions_block_content_create_access
Found when trying to fix the core bug 🐛 Block content permissions required to select or upload new Media with media library when using Layout Builder Active
Needs work
1.0
Code
The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
I think this would be the perfect time to introduce some tests for the module since this is a fairly big change.