- last update
over 2 years ago 54 pass, 2 fail - π³πΏNew Zealand RoSk0 Wellington
Updated patch version based on #10, but with some changes. No interdiff as patch from #10 wasn't applying to 2.x branch.
Changes:
added upgrade path - it sets the value to the current 100 items to preserve behaviour, default value for new installations will be 600 as I figured this number better represents "ideal conditions" and safe for both URL and tag type purges
changed description of the limit on settings form to be more explicit about the meaning The last submitted patch, 14: cloudflare-3132912-14.patch, failed testing. View results β
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.- last update
over 2 years ago Composer require failure - last update
over 2 years ago 54 pass, 2 fail - last update
over 2 years ago 60 pass - π³πΏNew Zealand RoSk0 Wellington
Changes:
- fixed test
- rename
ideal_conditions_limit
=>purge_limit
to be more meaningful - moved purger settings into separate section on the settings form
- improved help text of the new setting
- Status changed to RTBC
over 1 year ago 3:36am 24 April 2024 - π³πΏNew Zealand ericgsmith
Have been using this patch for a long time in production for multiple sites now without issue. Looks good and works a treat
- Status changed to Needs work
over 1 year ago 11:05pm 25 April 2024 - π³πΏNew Zealand ericgsmith
While my review above that this works well stands, I've noticed π Excessive Tag Hash Collisions Fixed introduced a new config schema and form for the cloudflarepurger sub module where as this is using the cloudflare settings.
I think the config here actually logically lives in the new sub module schema? Its a bit messy as the purger would then need to reply on both the cloudflare and cloudflarepurger config.
- Merge request !29#3132912: Override getIdealConditionsLimit and make it configurable β (Open) created by ericgsmith
- π³πΏNew Zealand ericgsmith
Unfortunately tests and a lot of linting jobs failing on 2.0.x branch - so the pipeline looks mess, but I've moved the config from cloudflare to cloudflarepurger module given there was a specific form added in π Excessive Tag Hash Collisions Fixed for the sub module config.
The only part I don't like is the purger needing both the
cloudflare.settings
andcloudflarepurger.settings
configs but π€·This also now has the benefit the the constant for the cache tags per request can be directly referenced - which also needs to be bumped in π Increase cache tags per request to 100 Active .
- π³πΏNew Zealand RoSk0 Wellington
This needs rebase and a changelog entry.
Also, is β¨ Raise cache tag purge limit Needs work related? Shall we look at them together? Or as part of the bigger picture?