The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- First commit to issue fork.
- Merge request !13169Issue #3129231: Allow the altering of the post_update run order. → (Open) created by joevagyok
- 🇺🇸United States nicxvan
I'll be honest, I have strong reservations about this.
We do have a way to order them already just by numbering them.
This looks suspiciously like hook module implements alter that was a monumental effort to replace.
Can we get a description of the scenarios where ordering is necessary here and why alpha numeric isn't sufficient?
I'd also want to review hook update dependencies in depth to see if that can be applied.
- 🇧🇪Belgium joevagyok
In the patch made for 10.5.x in comment #27 I realized that one function call is missing and the feature doesn't work as expected. Uploading the correct patch.
- 🇧🇪Belgium joevagyok
@nicxvan Our use case that requires this is the following:
We have an install profile and we need to make sure, that all dependent components/modules run their post_update functions before the install profile post updates, hence why the existing solutions are not enough, like it is described in the issue description. - 🇧🇪Belgium joevagyok
Added the missing part in the 10.5.x patch.
public function getPendingUpdateFunctions() { ... return $this->alterAvailableUpdateFunctions($not_executed_update_functions);