If race condition appears and RecurringOrderManager::renewOrder is executed then duplicated order will be created.
It may happen if advancedqueue executed job item in the same time from cron, automated cron or user paid via UI.
Suggestions:
- Lock renewOrder by subscription id, prevent the same order manipulation in parallel
- Check if order for the next billing period already exists
Closed: duplicate
1.0
Code
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
Re-rolling patch #7 against 1.0-rc1
Fix the missing line.
Patch #13 breaks order renewal because there is still a reference to the removed createOrder() function.
Here is the fix.
The prefered approach is the cron fix.
The advancedqueue patch has been committed, and the patch leveraging it is ready (See
🐛
multiple recurring orders get created if cron is badly configured
Needs work
)L