- πΊπΈUnited States kevinquillen
I can't get a list of channels either.
It seems like the module loses the ones returned from the API here:
$channels = array_filter($channels, function (Channel $channel) { return $channel->getPlatform() === CreateChannelRequest::PLATFORM_DRUPAL; });
Why does this care if the channel name is 'drupal'?
- πΊπΈUnited States kevinquillen
I removed that line of code and added the channel ID for clarity:
$list = []; foreach ($channels as $channel) { $list[$channel->getId()] = $channel->getName() . ' (channel ID: ' . $channel->getId() . ')'; }
in the option list. Now I can select any channel made from BC.
It seems like this code only existed to show you only the channels that were created from Drupal, as opposed to selecting any channels already made in BC.
- πΊπΈUnited States kevinquillen
Also - it is possible that a user may not have permission to create a channel. So I would think we should not limit these options to only channels made from within Drupal, or users get stuck.
-
kevinquillen β
committed e8a94940 on 2.0.x
Issue #3128150 by kevinquillen: Cannot create a channel ID
-
kevinquillen β
committed e8a94940 on 2.0.x
- πΊπΈUnited States kevinquillen
Unless anyone has objections - I will remove that filter. I only see the constant referenced in just one place. Can anyone explain why you'd only want to list channels that were made in Drupal vs any existing channels in BigCommerce? (I am not sure what the importance there is).
- Status changed to Needs review
over 1 year ago 6:31pm 7 September 2023