- πΊπΈUnited States nicxvan
The code mentioned in the issue summary has been updated.
Further, I can't imagine not showing a hidden dependency, that would be a huge point of confusion.
There is a todo pointing to this issue so assuming we don't do this at need to remove that.
- πΊπΈUnited States bnjmnm Ann Arbor, MI
Further, I can't imagine not showing a hidden dependency, that would be a huge point of confusion.
I'm inclined to agree. This issue was filed because
- there were comments in core indicating hidden modules exclusion from "depends on" was the intended functionality, but the code was failing to achieve that.
- Giving the above finding it's own issue make it possible to unblock progress on a the more important issue where the above happened to be found
I was leaning towards keeping things as-is even when this issue was initially filed, and considering 5 additional years have since passed since I'm not sure there's anything that needs changing aside from possibly pruning the
@todo
s - πΊπΈUnited States nicxvan
Since we're in agreement I've removed both todos and updated the metadata.
I'll keep an eye on random fails.
- πΊπΈUnited States bnjmnm Ann Arbor, MI
I'm good with this approach, I think it's more accurate to see this as a stale @todo vs functionality that needs to be changed.
Automatically closed - issue fixed for 2 weeks with no activity.