- 🇩🇪Germany gooddev
For me patch #4 was working, without the need to apply any additional patch from ticket https://www.drupal.org/project/decoupled_router/issues/3111456 🐛 Unable to resolve path on node in other language than default Needs work
I also was trying to apply patch#17 and #6 in combination with patch #64 from issue 3111456, but there was no way of bringing this to work with both entity types (node and commerce_product).
Atm it seems like #4 solved the problems.
thanks!
- Merge request !15Cannot generate the entity canonical url by passing the entity UUID → (Open) created by mglaman
- last update
12 months ago 4 pass - 🇺🇸United States mglaman WI, USA
I've opened https://git.drupalcode.org/project/decoupled_router/-/merge_requests/15 from patch #4. Cleaning up patch files.
- Assigned to mglaman
- Status changed to Needs work
12 months ago 6:42pm 19 December 2023 - 🇺🇸United States mglaman WI, USA
I'd like to commit this, but we need a test. I've started on one but I don't know how to reproduce this. Is it caused by having an Entity UUID param converter generally available?
\Drupal\jsonapi\ParamConverter\EntityUuidConverter
only applies to JSON:API routes. Does this require a custom param converter? The issue summary alludes to that:When a param converter applies to the entity canonical route
It's been a long time, but I wonder if we hit this way back due to commerce_api and its
EntityUuidConverter
applying to all Commerce routes.So the test would need to provide a general UUID converter that has
entity_uuid
in its service name.While writing this I think I answered my own question. Working on the test.
- last update
12 months ago 7 pass - Issue was unassigned.
- Status changed to Needs review
12 months ago 8:57pm 19 December 2023 - 🇺🇸United States mglaman WI, USA
Okay, I got a test running with a sample UUID param converter. Without the fix, the test doesn't fail on
\d+
validation, but the URL is always wrong.The test validates
/entity_test/01deaea2-e5dc-4255-8d97-ba0543cf790b
,/entity_test/1
, and/entity-test
all resolve the same canonical URL for the test entity. - last update
12 months ago 7 pass This patch was failing, probably because there isn't a Kernel directory in the test. I just made one so I could try this patch and see if it fixes my problem. That might be the wrong answer.