Should SearchApiDisplay extend SearchApiBaseFacetSource?

Created on 10 February 2020, over 4 years ago
Updated 15 March 2024, 4 months ago

In the code comments for the __construct() method of Drupal\facets\Plugin\facets\facet_source\SearchApiDisplay, it is indicated that a new SearchApiBaseFacetSource object should be created:

* Constructs a SearchApiBaseFacetSource object.

SearchApiDisplay extends FacetSourcePluginBase, which does not appear to extend SearchApiBaseFacetSource anywhere in its hierarchy.

Is this an erroneous comment, or should SearchApiDisplay extend SearchApiBaseFacetSource?

πŸ’¬ Support request
Status

Needs review

Version

3.0

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States BeauTownsend

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.69.0 2024