Mail Safety: Intercept outbound messages but optionally respond with $mail['result'] = TRUE so that front end user experience remains the same

Use Case #1:

As a UAT user, I am issuing a password reset by following the "Reset your password" form instructions. After entering my email address and hitting submit, Drupal puts me on the User Login page, but the "Further instructions have been sent to your email address." message does not show.

On the surface, it appears that the intercepting mail plugin Mail Safety could optionally return at least $mail['result'] = TRUE; so that in user.module:1279 return empty($mail) ? NULL : $mail['result']; might be satisfied. I suggest optional, because maybe not everyone wants it .. or maybe not all the time.

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment 8 months ago →
🇩🇪Germany anruether Bonn
This is can be really confusing. E.g. in this case:

In /admin/config/people/accounts

Set Who can register accounts? > Visitors

Check Require email verification when a visitor creates an account

As anonymous user, go to /user/register

On clicking register, see that user is not redirected to frontpage and no message is shown, as would usually be the case
First commit to issue fork.
Status changed to Needs review 8 months ago9:30pm 14 July 2024
Comment 8 months ago →
🇩🇪Germany geek-merlin Freiburg, Germany
Interesting! This one should fix it.
Comment 8 months ago →
🇩🇪Germany geek-merlin Freiburg, Germany
geek-merlin → changed the visibility of the branch 3111367-fix-send-result to hidden.
Comment 8 months ago →
🇩🇪Germany geek-merlin Freiburg, Germany
Merge request !9Fix mail sent result #3111367 → (Open) created by geek-merlin
Comment 8 months ago →
🇩🇪Germany geek-merlin Freiburg, Germany
Commit to test: https://git.drupalcode.org/issue/mail_safety-3111367/-/commit/3e20ff0ad2...
Pipeline finished with Success
8 months ago
Total: 161s
#224105
Status changed to Needs work 8 months ago2:39pm 15 July 2024
Comment 8 months ago →
🇩🇪Germany geek-merlin Freiburg, Germany
Nope, that does not work out.
How to fix:
- Decorate MailManager
- Override Mailsystem config
I'd favor the latter.

Mail Safety: Intercept outbound messages but optionally respond with $mail['result'] = TRUE so that front end user experience remains the same

Use Case #1:

Merge Requests

!9Mail Safety: Intercept outbound messages but optionally respond with $mail['result'] = TRUE so that front end user experience remains the same
Open

Comments & Activities

Mail Safety: Intercept outbound messages but optionally respond with $mail['result'] = TRUE so that front end user experience remains the same

Use Case #1:

Merge Requests

!9Mail Safety: Intercept outbound messages but optionally respond with $mail['result'] = TRUE so that front end user experience remains the sameOpen

Comments & Activities

!9Mail Safety: Intercept outbound messages but optionally respond with $mail['result'] = TRUE so that front end user experience remains the same
Open