Only warm published entities

We do have this same need in a client project. Trying to get a working solution.

Hi!

Worked on a MR to try to provide the feature to all the entity types that implements EntityPublishedInterface.

However, we had to check it at query time, so $entity instanceof EntityPublishedInterface or $entity->isPublished() won't work because entities need to be loaded and the aim of this issue is to do not load them.

Instead, we assumed that entities are implementing EntityPublishedTrait and isPublished() method is not overridden. Following that approach, we can get the entity property that stores the publishing information and add it to the query.

Checked core entity types that implement the interface above and I think it would work in this way for all of them, but cannot guarantee for other entity types declared by contrib modules. Also reviewed entity types provided by commerce and they respect this pattern.

What do you think?

While working on this, also found that as part of D10 migration ->accessCheck(TRUE) was added to the general queue for the entity warmer. This means that not all the entities would warmed, causing possible unexpected results.

Should we change that line to ->accessCheck(FALSE) by default?
In that case we could set it back to TRUE if the publised only option is set to TRUE, even if that's not exactly the same.

Thank you!

Should we change that line to ->accessCheck(FALSE) by default?

Yes. That was an oversight. Thanks for catching it!

Merged! Thanks all.

Added an empty commit to include more issue credit. Apologies.

Automatically closed - issue fixed for 2 weeks with no activity.