Suggestion search - min length

Created on 6 November 2019, about 5 years ago
Updated 9 May 2024, 7 months ago

Problem/Motivation

When there is enough content amount on the site, searches on a single letter could cause many issues like out of memory and time limits.

As it is the module is triggering suggestions search if there is something in the search term.
Searching by a single character WILL be heavy, even if it is possible in theory.

Proposed resolution

In almost all search servers there is a minimal search term length.
SOLR server defaults to 4 characters to trigger a viable search.

I propose to expose a profile level configuration that will designate the minimum characters length to trigger results from linkit suggestion plugins.

We can have a default that is as it currently is 1 for existing installations.
I think a reasonable default going in the future would be 2 or 3 characters.

Remaining tasks

Approval of direction, patch, etc...

User interface changes

New configuration.
Small change in suggestions UI (we might need more input to trigger suggestions).

API changes

None.
The change should affect link-it module internals and not affect provider plugins.

Data model changes

New configuration (API addition).

Release notes snippet

Mention it...

✨ Feature request
Status

Closed: won't fix

Version

5.0

Component

Code

Created by

πŸ‡§πŸ‡¬Bulgaria ndobromirov

Live updates comments and jobs are added and updated live.
  • Performance

    It affects performance. It is often combined with the Needs profiling tag.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • πŸ‡ΊπŸ‡ΈUnited States mark_fullmer Tucson

    For some time now, as indicated by the Linkit project page β†’ , the 8.x-5.x branch of Linkit is not undergoing active development. It is also only compatible with unsupported versions of Drupal core (Drupal 8 and Drupal 9).

    To help the maintainers of the Linkit module better steward tasks under active development, I'm going to mark this issue as closed (wontfix). Sites using 8.x-5.x can certainly continue to do so, but should make plans for updating to the latest supported version of Linkit.

    Even better: Drupal core will soon provide link autocomplete suggestions in CKEditor similar to what this module does. Sites using or considering using Linkit should follow this core issue ✨ Drastically improve the linking experience in CKEditor 5 Needs work to evaluate whether they can use the core solution instead of Linkit. See feature differences below to compare what Linkit includes that will not initially be in Drupal core.

    If this issue relates to a problem or feature request that is applicable to the latest supported version of Linkit, please create a new issue, associated with that branch, describing the bug or enhancement.

    For participation and information in Linkit's roadmap, see 🌱 LinkIt Release Roadmap and Issue Prioritization Active .

    Thanks, community, for you collaboration and consideration!

Production build 0.71.5 2024