- πΊπΈUnited States mlncn Minneapolis, MN, USA
This i believe caused the problems in π workflow_buttons should only be loaded/load edit form when relevant Fixed so we have some cleanup here to regain this functionality again, my bad for bringing it in without enough testing and somehow not creating a new branch like i meant to.
- πΊπΈUnited States beunerd Providence, Rhode Island
@mlncn
What functionality is missing / needs to be regained? I've created a branch on the forked code, but I'm not sure what I need to work on.
- πΊπΈUnited States beunerd Providence, Rhode Island
@mlncn
I think this should be marked as fixed and merged in. The "workflow buttons" pseudo field can be placed on any view display via UI/configuration. Its visibility to users, then, is handled by Drupal's standard "workflows" permissions. And please see https://www.drupal.org/project/workflow_buttons/issues/3328538 π workflow_buttons should only be loaded/load edit form when relevant Fixed for more.
- Status changed to RTBC
over 1 year ago 2:36pm 24 August 2023 - π―π΅Japan ultrabob Japan
I found this issue looking for a way to show the workflow buttons on the view for a custom entity. I confirmed that this functionality seems to be in place for nodes, so suggest marking it as fixed. I will likely create a feature request for the ability to add this to custom entities that have a workflow enabled.
- πΊπΈUnited States mlncn Minneapolis, MN, USA
Making a release and i guess we can call this fixed for now, but surely we need something more to make this feature actually useful?
Realizing that same-to-same transitions really don't make sense when viewing a piece of contentβ "Save" (or even "Save as Draft") makes no sense when viewing, only "Publish" or "Unpublish (demote to draft)" and stuff like that makes sense.
Also, it does load maybe more than it has to starting from
workflow_buttons_entity_view
and src/Plugin/Field/FieldWidget for people who have no permission to edit (and so no permission to use buttons) that we could perhaps bail out of sooner. - π―π΅Japan ultrabob Japan
I've used this extensively first on nodes and later on other custom entities, for workflows where we need certain people to just review the content, and are not expected to make any changes to it. I control what buttons are displayed with transition permissions, but like you so, I usually hide the same to same transition when on an entity view, rather than the edit form. I'll be talking about this module at DrupalCon should my session be accepted, so I do think this feature is already useful.
- Status changed to Fixed
about 1 year ago 4:19am 13 December 2023 - πΊπΈUnited States mlncn Minneapolis, MN, USA
Cool, ultrabob! You are using a custom alter to hide the inapplicable transitions/buttons or some other method? Would be great to document or incorporate into the module. Also, made you a maintainer since you have been doing that issue curation work already thank you!
Automatically closed - issue fixed for 2 weeks with no activity.