- First commit to issue fork.
- Status changed to Needs review
11 months ago 10:27am 30 May 2024 Re-rolled the patch from #8 on top of 2.x into an MR, fixed a bunch of issues reported by PHPCS and addressed review comments in #10. phpstan fails are still tbd, but moving into review anyway as it would be good if someone would test and review the code changes.
- Status changed to Postponed
10 months ago 12:02am 11 June 2024 - 🇦🇺Australia acbramley
Once 📌 Switch Node revision UI to generic UI Needs review is in Core, Diff will move to support all entity types generically. Until that is done, we cannot duplicate code for other entity types. Feel free to continue to use a patch or spinoff another module.
Diff will move to support all entity types generically.
Please correct me if I'm wrong, but I think in order to support groups there will still be a requirement for some extra code, at least in order to consider group permissions when rendering the view/revert/delete links on the revision overview form. I just added this case in the MR.
Agree that this logic should probably live in a separate module, possibly a submodule of diff that depends on group? But as you say, until the "generic entity support" refactoring for the diff module happened, it probably doesn't make sense to proceed any further.
- 🇦🇺Australia acbramley
Please correct me if I'm wrong, but I think in order to support groups there will still be a requirement for some extra code, at least in order to consider group permissions when rendering the view/revert/delete links on the revision overview form.
Group should handle the access for these operations itself. The generic revision UI just uses
$revision->toUrl('revision-delete-form');etc so Group will have to implement access handler cases for those operations, see core's implementation for Block content
