Library definition does not correspond with library setup

Created on 1 October 2019, about 5 years ago
Updated 22 February 2023, almost 2 years ago

views_slideshow_jcarousel.libraries.yml defines a path to the jcarousel library that will not exist if you download current version (0.3.9) of the plugin from https://github.com/jsor/jcarousel.

The libraries.yml points to a path "lib" that does not exist, instead it should point to path "dist". It seems that path "lib" is leftover from D7 module where an older version of the plugin (0.2.9) needs to be used.

In addition there is a library definition for library "views_slideshow_skins" which does not exist anymore with the 0.3.9 version. The library is "views_slideshow_skins" is also not used anywhere in the D8 module as far as I can see. So this could be removed from libraries.yml.

I will provide a patch for this.

🐛 Bug report
Status

RTBC

Version

1.0

Component

Code

Created by

🇩🇪Germany stefan.korn Jossgrund

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.71.5 2024