Library name should lower case (not Capital Case) and Library should be installed via Composer

Created on 25 September 2019, about 5 years ago
Updated 3 June 2024, 7 months ago

I'd like to see a little better documentation about the library location name.

The docs and module home page doesn't give clear instructions on how to spell the Magnific-Popup libraries folder.

I'd like to see the following re-written in the README.txt, along with a similar update on the home page:

Download Magnific-popup (https://github.com/dimsemenov/Magnific-Popup) library and place it in the libraries folder (/libraries).

to something like:

Download Magnific-popup (https://github.com/dimsemenov/Magnific-Popup) library and place it in the libraries folder (/libraries).  Make sure the libraries root folder name is "Magnific-Popup" which is case sensitive.  For example: (/libraries/Magnific-Popup)

I apologize for not being able to add a patch, but hopefully this will help others who aren't 100% sure based on the current docs and haven't quite figured it out from trial and error.

πŸ› Bug report
Status

Active

Component

Documentation

Created by

πŸ‡ΊπŸ‡ΈUnited States philsward

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • πŸ‡©πŸ‡ͺGermany ktpm

    For anyone stumbling on this:

    Until this is fixed someday, you can override the file path(s) of the library in your theme's info.yml:

    libraries-override:
        fiu/magnific:
        js:
          /libraries/Magnific-Popup/dist/jquery.magnific-popup.min.js: /libraries/magnific-popup/dist/jquery.magnific-popup.min.js
        css:
          theme:
            /libraries/Magnific-Popup/dist/magnific-popup.css: /libraries/magnific-popup/dist/magnific-popup.css
    

    Reference: https://www.drupal.org/node/2497313 β†’

Production build 0.71.5 2024