Incompatible with Config Ignore

Created on 19 September 2019, about 5 years ago
Updated 16 October 2023, about 1 year ago

When installing this module together with Config Ignore , the functions provided by that module do not work.

Considering that of 30K sites that report having Config Filter installed, 18K also have Config Ignore, this seems to be a major problem with this module.

🐛 Bug report
Status

Fixed

Component

Code

Created by

🇵🇹Portugal jcnventura

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • @tstoeckler opened merge request.
  • 🇩🇪Germany tstoeckler Essen, Germany

    Added a test for this and it passed without the patch in #2. (To be sure I also locally increased the weight to 150 and it still passed.) I then went ahead and tried it out locally and could verify it working as well.

    Not exactly sure what the issue was originally. I wouldn't be surprised if #2989520: Fix deleting shipped configuration entities fixed this. The way I see this it makes sense that both scenarios work when importing config (Config Ignore does not affect the config export, so that is not relevant):

    Scenario A: Config Ignore first then Config Overlay (this is what currently happens)
    - We start with the minimal export because Config Overlay removed a bunch of stuff
    - Config Ignore adds the active configuration for any ignored config (or overrides the exported one if it was exported)
    - Config Overlay adds in all shipped configuration. Because it sees the active configuration for all the ignored configuration as though it had been exported it does not override it

    Scenario B: Config Overlay first then Config Ignore (this is what happens with #2)
    - We start with the minimal export because Config Overlay removed a bunch of stuff
    - Config Overlay adds in all shipped configuration
    - Config Ignore overrides the ignored config with the active configuration

    I do think the current way makes more sense (although I guess that is arguable) and it is slightly more efficient because Config Overlay will not fetch the ignored configuration only for it to be overridden. Currently Config Overlay is only after Config Ignore incidentally due to naming, as both declare a weight of 100. So having written this I think it makes sense to change this to 150 for Config Overlay to make this more explicit.

    • tstoeckler committed c499df26 on 8.x-1.x
      Issue #3082392 by tstoeckler: Add test for Config Ignore integration
      
  • Status changed to Fixed about 1 year ago
  • 🇩🇪Germany tstoeckler Essen, Germany
  • 🇩🇪Germany tstoeckler Essen, Germany
  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024