- @tstoeckler opened merge request.
- 🇩🇪Germany tstoeckler Essen, Germany
Added a test for this and it passed without the patch in #2. (To be sure I also locally increased the weight to 150 and it still passed.) I then went ahead and tried it out locally and could verify it working as well.
Not exactly sure what the issue was originally. I wouldn't be surprised if #2989520: Fix deleting shipped configuration entities → fixed this. The way I see this it makes sense that both scenarios work when importing config (Config Ignore does not affect the config export, so that is not relevant):
Scenario A: Config Ignore first then Config Overlay (this is what currently happens)
- We start with the minimal export because Config Overlay removed a bunch of stuff
- Config Ignore adds the active configuration for any ignored config (or overrides the exported one if it was exported)
- Config Overlay adds in all shipped configuration. Because it sees the active configuration for all the ignored configuration as though it had been exported it does not override itScenario B: Config Overlay first then Config Ignore (this is what happens with #2)
- We start with the minimal export because Config Overlay removed a bunch of stuff
- Config Overlay adds in all shipped configuration
- Config Ignore overrides the ignored config with the active configurationI do think the current way makes more sense (although I guess that is arguable) and it is slightly more efficient because Config Overlay will not fetch the ignored configuration only for it to be overridden. Currently Config Overlay is only after Config Ignore incidentally due to naming, as both declare a weight of 100. So having written this I think it makes sense to change this to 150 for Config Overlay to make this more explicit.
-
tstoeckler →
committed c499df26 on 8.x-1.x
Issue #3082392 by tstoeckler: Add test for Config Ignore integration
-
tstoeckler →
committed c499df26 on 8.x-1.x
- Status changed to Fixed
about 1 year ago 11:05pm 16 October 2023 Automatically closed - issue fixed for 2 weeks with no activity.