Use minified version of jquery.blockUI

Created on 17 July 2019, over 5 years ago
Updated 20 July 2023, over 1 year ago

Problem/Motivation

Currently, the module loads jquery.blockUI.js, which is not the minified / production-ready version. In order to improve the performance of our sites, we should use the minified version of the library.

Proposed resolution

Use http://malsup.github.io/min/jquery.blockUI.min.js.

📌 Task
Status

Needs review

Version

1.0

Component

Code

Created by

🇸🇮Slovenia sasanikolic

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • 🇮🇳India heykarthikwithu Bengaluru 🌍

    Can we put the original URL instead of downloaded file?
    let me know your thoughts?
    Otherwise patch is working fine with both cases, with downloaded file as well as with original url http://malsup.github.io/min/jquery.blockUI.min.js as shown in below example.

    diff --git a/ajax_screen_lock.libraries.yml b/ajax_screen_lock.libraries.yml
    index be56794..4aaea70 100644
    --- a/ajax_screen_lock.libraries.yml
    +++ b/ajax_screen_lock.libraries.yml
    @@ -5,7 +5,7 @@ jquery-blockui:
         gpl-compatible: true
       js:
         # Blocked by https://www.drupal.org/node/2605130
    -    /libraries/jQuery.blockUI/jquery.blockUI.js: {}
    +    http://malsup.github.io/min/jquery.blockUI.min.js: { type: external, minified: true }
     
     ajax-screen-lock:
       version: VERSION
    @@ -13,4 +13,4 @@ ajax-screen-lock:
         misc/ajax-screen-lock.js: {}
       css:
         component:
    -      misc/ajax-screen-lock.css: {}
    \ No newline at end of file
    +      misc/ajax-screen-lock.css: {}
Production build 0.71.5 2024