Aggregation is not grouping correctly

Created on 9 July 2019, almost 5 years ago

Updated 20 October 2023, 8 months ago

Problem/Motivation

Regardless of whether we have a library containing a JS file in a custom module or within our theme, whenever we add attributes: { defer: true } it is still being grouped with the other JS files where the defer attribute is not set.

Proposed/Resolution

Group all JS files that have defer: true together
Group all JS files that have async: true together
Group all JS files that do not have both set (async and defer) together

Steps to reproduce

Enable advagg_bundler,advagg_css_minify,advagg_js_minify,advagg_modadvagg modules

Under configuration (/admin/config/development/performance/advagg):

Enabled Advanced Aggreation = true
Use DNS Prefetch for external CSS/JS = true
keep all other settings as defaults

Under Bundler (/admin/config/development/performance/advagg/bundler)

Bundler is active = true
css bundling option: target number = 4 & grouping logic = file size
JS bundling option: target number = 4 & grouping logic = file size

CSS Minifications (/admin/config/development/performance/advagg/css-minify)

Minification = Core

JS Minifications (/admin/config/development/performance/advagg/js-minify)

JSqueeze = enabled

Modifications (/admin/config/development/performance/advagg/mod)

JS: Enabled preprocess on all JS = True, Move all external scripts to the top of the execution order = True, Move all browser conditional JavaScript to the bottom of the group = true
CSS: Enable preprocess on all CSS, Move all external CSS to the top of the execution order = true, Move all browser conditional CSS to the bottom of the group = true

🐛 Bug report

Status

Active

Version

4.0

Component

Code

Created by

drup16

Live updates comments and jobs are added and updated live.

Incomplete comments

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment 8 months ago →
🇫🇷France prudloff Lille
JS: Enabled preprocess on all JS = True

AssetResolver:getJsAssets() adds preprocess: false on scripts with attributes like defer or async because it can't handle them correctly.
The "Enabled preprocess on all JS" option bypasses this logic and agregates these scripts regardless but loses the attributes.

This could be fixed by 💬 Aggregate and bundle only JavaScript with defer without forcing all to defer? Needs work and 🐛 JavaScript aggregation should account for "async" and "defer" attributes Needs work .

contrib.social Blog FAQ Discussions

Production build 0.69.0 2024