improvement proposal on session variables use and campaign_id value retrieval

Created on 27 June 2019, over 5 years ago

Updated 11 December 2024, 11 days ago

Hi, I propose some changes on 2 function in mailchimp_ecommerce.module:

mailchimp_ecommerce_page_attachments
mailchimp_ecommerce_get_campaign_id

The changes on mailchimp_ecommerce_page_attachments are basically a try to do the things in "the Drupal way".
Essentially to prevent unwanted behavior in the presence of aggressive caching like Varnish.

In the mailchimp_ecommerce_get_campaign_id I only add an alter hook to allow other modules to alter the campaign_id.
In the comment I also provided a simple use case:
"you have an audience for B2B and another for B2C customers so you may want to differentiate the campaign automation".

What do you think?

📌 Task

Status

Active

Version

1.0

Component

Code

Created by

🇮🇹Italy emanuelrighetto Verona

Live updates comments and jobs are added and updated live.

Incomplete comments

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment 11 days ago →

System Message

xenophyle → committed d1c37a4b on 2.x

Issue #3064660 by emanuelrighetto: improvement proposal on session...

Comment 11 days ago →
🇺🇸United States xenophyle
Some of these changes were done recently as part of another fix. I added some of the changes for the mailchimp_ecommerce_page_attachments() part but won't be adding an alter hook for the campaign ID since it is no longer being sent to the API (https://mailchimp.com/help/about-mailchimp-attribution/).

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024