- π§πͺBelgium borisson_ Mechelen, π§πͺ
Sure, this could be a great improvement and I'm willing to accept a patch that fixes these points.
- π¬π§United Kingdom oily Greater London
andrew.farquharson β made their first commit to this issueβs fork.
- @andrewfarquharson opened merge request.
- @andrewfarquharson opened merge request.
- Status changed to Needs work
about 2 years ago 2:57am 23 April 2023 - π³π±Netherlands neograph734 Netherlands
Although this appears to be removing a lot of duplicate code, it is not solving the issue I initially described.
I was requesting a universal entity bundle processor for every entity type. Something that should be possible with the direction given in the issue summary.
- π¬π§United Kingdom oily Greater London
@Neograph734 Yes, the issue is not complete which is why i have put the status to 'Needs Work'. I am using Agile approach. You or someone else can complete it. But i would say that your request for a 'Universal processor' could be opened as a new issue with that title which you have not used before, since it will involve several sub-steps to achieve. Can you please assist in closing this ticket and raising the new one with a draft of the steps required to do it.
- π³π±Netherlands neograph734 Netherlands
Hi Andrew,
Please realize that I created this post 4 years ago. I currently have no need for this module anymore and I don't fully remember what I thought back then.
But yes, your steps look complete.
if ($datasource->getEntityTypeId() == $this->entitytypeId) {
I suppose you can skip this check to have the trait compatible with all entities.And I suppose you can add a new class for general entities, then have the node, and other classes extend that one for backwards compatibility. (Optionally mark them deprecated.)
But this is all the guidance I can currently give. In comment #8 I only wanted to warn you that you should not spend a lot of time not solving the issue.
Thanks for working on this anyway! - π¬π§United Kingdom oily Greater London
Hi Neograph734, Okay thank you for the feedback! Going to have a deeper dive into the search api and where processors fit into it before attempting any MR