Timezone selection not working properly

Patch #8 didn't apply for me on 2.04 because of a single space. Attaching a fix!

Sorry, messed #9 up...this one should work.

This new MR addresses the timezone issue more directly. Checking for "T" isn't reliable given the various forms of date strings we might see, including something like "DTSTART;TZID=America/New_York:19980312T083000"

The ICal\ICal class provides the timezone in the date arrays like
Array ( [0] => Array ( [TZID] => Europe/Berlin ) [1] => 20240410T140000 [2] => 1712750400 [3] => TZID=Europe/Berlin:20240410T140000 )

In this way, we can identify if a timezone was provided and use it appropriately, which in the case above involves formatting the date string like:
20240410T140000Europe/Berlin

See related Feeds issue: https://www.drupal.org/project/feeds/issues/3070757 →

With this MR, formatting using the provided timezone results in the Feeds DateTargetBase class creating the date using the provided timezone. See: https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Datetime%...

"Note that the $timezone parameter and the current
* timezone are ignored when the $time parameter either is a UNIX timestamp
* (e.g. @946684800) or specifies a timezone
* (e.g. 2010-01-28T15:00:00+02:00)."

In my testing imported events without timezone were unaffected, while events with them were adjusted accordingly to match my site's default setting.

If I could get some testing here that would be awesome! Thanks!

In my Feeds mapping I have selected DTSTART (unix timestamp) and when there is a timezone in the feed I am now getting a string such as 20250405T120000America/New_York, which is causing fatal PHP errors when I pass it to date(). This is almost certainly a change in behavior. There is a mapping for DTSTART RAW (string format from source) but I have never used it.

Feeds that don't use a TZID specification continue to return the timestamp to my processor as always.

Of course, correct processing of timezone is important, but I hope we can keep the behavior of returning a unix timestamp when specified.

Thanks @peter pulsifer I will take a look at this tomorrow. That mapping should indeed pass the timestamp directly.
Are you able to share an example .ics / .ical that you're working with?

Thanks @ben.hamelin. One example feed is https://griffinmuseum.org/events/?ical=1.
This one has no TZID and the importer gives the timestamp: http://api.membershipworks.com/v2/events?_op=ics&org=14015

@peter pulsifer Sorry I am battling with Gitlab.... going to open a new issue so this is quicker. I can't seem to rebase the issue fork from the source project from the Gitlab UI.

https://www.drupal.org/project/feeds_ical/issues/3517541 🐛 Provide timezone fields and retain UNIX TIMESTAMP Active