Extend this to work with eck types and paragraphs

Created on 29 May 2019, over 5 years ago
Updated 31 August 2024, 4 months ago

Does this also work for paragraphs and eck entity types and bundles?

Thanks

Feature request
Status

Needs work

Version

3.0

Component

Code

Created by

🇬🇧United Kingdom Syntapse

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • First commit to issue fork.
  • 🇮🇪Ireland lostcarpark

    This looks like a useful change. I would like to do some manual testing. Also, I think additional automated tests are needed to verify.

  • 🇮🇪Ireland lostcarpark

    I've looked at including this change in the 8.x-3.11 release of Scheduled Publish, but have decided to defer for the following reasons:

    The change needs a rebase (if that was all, I'd be happy to do it but...)
    I feel that adding media support is a big enough change that it needs a test case
    The proposed method of handing entity types requires every new type to be hard coded into the doUpdateFor function. This has potential to get unwieldy if more content types are supported, and if an organization has custom entity types, they would need to patch the module to support them.

    I propose we replace the doUpdateFor with a plugin service. Plugins for Nodes and Media could be included in the module, and additional ones could be added later. Additionally, it would allow anyone to schedule custom entity types by creating their own plugin.

    Happy to work on this after current release.

  • Status changed to Needs work 4 months ago
  • 🇮🇪Ireland lostcarpark

    Setting to needs review.

  • 🇮🇪Ireland lostcarpark

    I misunderstood this change the first time I looked at it, and now I've had another look, I can see it's a very clean method of making the module properly generic.

    I think the change looks great, but I think it needs a test to ensure future changes that assume nodes don't cause regression issues.

    I'll try to work on a test for this.

Production build 0.71.5 2024