Circular dependencies in EntityReferenceRevisionsFieldItemList::hasAffectingChanges();

Created on 12 March 2019, over 6 years ago
Updated 19 November 2023, almost 2 years ago

We found an issue with EntityReferenceRevisionsFieldItemList::hasAffectingChanges()

We have a structur like this:

Node A -> Paragraph -> Node B -> Paragraph -> Node C -> Paragraph -> Node B

As you can see there is a circular dependency between Node B and Node C. So when we try to save Node A we get stuck in a infinite loop due to hasAffectingChanges() calling hasTranslationChanges() which in return calls hasAffectingChanges().

I have created a simple patch that works for us, but I don't think it's the correct solution. My guess is that hasAffectingChanges() should check what kind of field it is before going deep down in the rabbit hole to find entities with affecting changes. But I don't have the knowledge needed to fully understand what this method is supposed to do, and why.

πŸ› Bug report
Status

Needs work

Version

1.6

Component

Code

Created by

πŸ‡ΈπŸ‡ͺSweden logaritmisk

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.71.5 2024