invalid service error when passing parameters like returnto

Changing branch for fork and begin merging into current HEAD.

Thank you for your efforts. I ended up going a different path, with some future changes in mind in handling the service url query parameters.

This is actually ready for review, but does include the contents of ✨ Restrict CAS log in to roles Needs review completely as the first commit - this obviously needs to be removed once that is merged first. My apologies for making this more difficult to review that it needs to be, but there are conflicting changes.

As the method signature is changing for ConfigHelper::matchServiceAgainstConfig(), it now deprecated in favour of ConfigHelper::loadServiceFromUri(). This both parses the service url and stores the results for later use. It seems folly to be running regex on the same string multiple times on the same request.

The service url is parsed using \Drupal\Component\Utility\UrlHelper::parse() to separate all of the parts. The path part is used for matching against the service entities, and the original url is used when redirected an authenticated user back to whence they came.

Could you please confirm that this will work for your situation?

Tests included in patch. Ready for next release.

De-assign.

Automatically closed - issue fixed for 2 weeks with no activity.