- Open on Drupal.org βCore: 10.2.1 + Environment: PHP 8.1 & MySQL 8last update
10 months ago Waiting for branch to pass - Status changed to Needs review
10 months ago 11:56am 29 February 2024 - Open on Drupal.org βCore: 10.2.1 + Environment: PHP 8.1 & MySQL 8last update
10 months ago Waiting for branch to pass - Open on Drupal.org βCore: 10.2.1 + Environment: PHP 8.1 & MySQL 8last update
10 months ago Waiting for branch to pass - π·πΈSerbia vaish
Here is a patch corresponding to the merge request from #10.
- Status changed to Needs work
9 months ago 9:10pm 13 March 2024 - πΊπΈUnited States chrisolof
This looks good and works well. Thanks Vaish!
I think we should remove the 'country-code' part, since it seems to just duplicate the "country" part. With that change we would match up to what data parts exist at the field's schema. Maybe someday we can open up another property here to expose country name, but probably not necessary at this point.
- Open on Drupal.org βCore: 10.2.1 + Environment: PHP 8.1 & MySQL 8last update
9 months ago Waiting for branch to pass - Status changed to Needs review
9 months ago 10:13am 14 March 2024 - π·πΈSerbia vaish
Thanks for the review, Chris. Composite element 'country-code' removed.
- Open on Drupal.org βCore: 10.2.1 + Environment: PHP 8.1 & MySQL 8last update
9 months ago Waiting for branch to pass - Status changed to Fixed
9 months ago 11:11am 18 March 2024 - πΊπΈUnited States mpaler
It's taken you guys long enough to fix this. Congrats!
- π·πΈSerbia vaish
Thanks @mpaler. All these years we were using the patch from #7 which did the job for us. But recently, the module got some updates and the patch couldn't be applied anymore. So instead of re-rolling the patch that will never be merged I worked on the proper solution. Better late than never.
Automatically closed - issue fixed for 2 weeks with no activity.