Move this bracket a bit?

Created on 23 February 2019, over 6 years ago
Updated 18 August 2025, 3 months ago

Hi!

#2928484: Continue shopping button has no hyperlink β†’ introduced a new bit in the js. While the check on top checks if (typeof settings.commerceAddToCartConfirmation != 'undefined') {} the new bit isn't inside this check. This leads to an error when the element isn't available & settings are not available (when attach is called by some other module). Leading to all kinds of issues with ajax forms, etc (nice stuff to debug).

Attached patch moves the new bit inside the check.

πŸ› Bug report
Status

Closed: outdated

Version

1.0

Component

Code

Created by

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.71.5 2024