- First commit to issue fork.
- 🇪🇸Spain tuwebo
I am working on 3031390-excerpt-shows-all-fields fork:
- Trying to solve handling for the borders between different values/fields
- Bypassing merging $keys if the backend found $highlighted_keys.
- PoC: For rendering the excerpt field names as part of the excerpt. It might be useful to know where the excerpt came from.Any review/contribution will be very welcome.
- Merge request !248#3031390 - handling borders between different fields, only use highlighted_keys if they exist add configuration for excerpt field labels → (Merged) created by tuwebo
- 🇪🇸Spain tuwebo
I am adding two related issues for this one work properly.
- 🐛 Replace deprecated REQUIREMENT_ERROR constant in search_api_db_defaults_requirements() for Drupal 11+ compatibility Active
will solve the failing test search_api_db_defaults\Functional\IntegrationTest::testInstallAndDefaultSetupWorking in this MR.
- 🐛 Values overwritten when multiple aggregated fields exist on same data source Needs work
is needed for taking into account any aggregated_fields in the excerpt.I think the only task pending could be a hook_update for updating indexes configuration to include:
$processors['highlight']['settings']['include_field_labels'] = FALSE; - 🇪🇸Spain tuwebo
I've merged the issue branch with the latest changes from 8.x-1.x (which includes around ~12 commits), so the only test that was failing now passes. All tests are passing and pipelines run with no issues.
Any review will be very welcome.There are some test added and new configuration for the Highlight processor to be able to show the field labels, since it helps the user to spot where the snippets are coming from.
See attached images: "drupal-search-api-3031390-15-01" and "drupal-search-api-3031390-15-02" - 🇦🇹Austria drunken monkey Vienna, Austria
Amazing work, thank you very much!
I left some comments in the MR and did some refactoring according to my personal preferences (plus minor code style fixes) but mostly this looks very good already. And thanks to our exhaustive test coverage I think we can be reasonably sure that all of this is working as it should.
The only things that still need to be addresses are the two unrelated features you added, which will need to be either ironed out or split into separate tickets, whichever you prefer. (See the unresolved threads in the MR.)In any case, thanks a lot again!
- 🇪🇸Spain tuwebo
Wow thank you so much for the review. I'll go through the MR comments and try to reply there, afterwards create a summary here in a new comment if necessary.
If for some reason (mostly lacking of time) you don't see me taking some action this week, please feel free to go ahead with whatever better suit the search api module needs.Thank you!
- 🇦🇹Austria drunken monkey Vienna, Austria
I split both of the new features into their own issues, I think this is probably easier to work with and should definitely make more sense when reviewing these changes in the future.
If you are fine with that, I think we can merge this one.In any case, thanks a lot again for all your work on this, sorry I had to complicate things with the new issues.
- 🇪🇸Spain tuwebo
Thank you very much for the review, I understand better now, and I totally agree to split the new features. I'll try to look at them in the coming days.
- 🇦🇹Austria drunken monkey Vienna, Austria
Great, thanks!
So, do you agree this is RTBC now, can I merge it? - 🇪🇸Spain tuwebo
I've just realized that config/schema/search_api.processor.schema.yml does no longer need include_field_labels, since we have a separate issue for it ✨ Optionally add field labels to excerpt snippets Active
- 🇦🇹Austria drunken monkey Vienna, Austria
Thanks, good catch!
Fixed that and merged.
Thanks a lot again, was a pleasure working with you on this! -
drunken monkey →
committed 9bc54a29 on 8.x-1.x authored by
tuwebo →
[#3031390] fix: Fixed excerpt to not include snippets from fields that...
-
drunken monkey →
committed 9bc54a29 on 8.x-1.x authored by
tuwebo →