Do not send notification if moderation state has not changed

#31, it seems you are working on a different issue, something related to coding standards, I would say.

Hello @rob-holmes, @jhedstrom

Could you please review this?

Thank you

FYI: it seems like the latest work on MR18 prevents sending notifications if the entity is new, which does not seem to be right. Could be a new entity in draft, but it might also be an entity immediately in review state, needing to have a notification sent.

Whilst we use notifications for state change transitions, we also use notifications specifically for same state transitions. This isn't a bug for us, it's currently logically working as per the granular one to one transitions we have setup (and have associated to notifications), and it seems this change would break this current feature for us. For context: these notification emails (for same state to same state) have email body content derived from other entities (through various custom twig functions) associated to this page. Yes, we could add this information onto the authenticated user’s page render, but this doesn't notify all reviewers with this new information (with notifications what this module is all about). We therefore have users editing content (e.g. transition state first_reviewer to state first_reviewer) that still need a notification.

Even though users could configure multiple transitions (to avoid same to same conditions) (like @drclaw #7 noted earlier) and associate applicable ones to notifications there seems to be appetite for this change. Therefore, as part of this fix can there also be an option to continue to allow same to same transitions. e.g. additional code changes for this issue to add a checkbox option with a label of "Send notification even if transition is to the same state" for each configured notification. In this way those of us who want the transitions to same states to still occur (the number that require this is somewhat unknown as I doubt module users would actively be looking for an issue like this) can have an option to continue to allow them.

@thierrybeeckmans It is sending a notification for a new entity.
@glena Added a new option to skip notifications for unchanged states.