Redirect loop error when re-saving node with existing redirect

Open on Drupal.org →

Created on 7 December 2018, about 6 years ago

Updated 12 August 2024, 5 months ago

We have a site with migrated content. When we migrated the content from D7 site, we created redirects from the path on the old site to the node on the new site - in case the paths were not the same. For example, redirect from /document/league-women-voters to /node/6271. Things have been working fine with no redirect loops (even when old website path and new website URL alias are the same) until we open one of these old migrated nodes and attempt to change it's title. If I change the title of the node to that it's new url would be /document/foo and save, I often see the following error:

The website encountered an unexpected error. Please try again later. Drupal\Core\Entity\EntityStorageException: Redirect loop identified at
/document/league-women-voters for redirect 2268 in Drupal\Core\Entity\Sql\SqlContentEntityStorage->save()
(line 783 of core/lib/Drupal/Core/Entity/Sql/SqlContentEntityStorage.php).
Drupal\redirect\RedirectRepository->findByRedirect(Object, 'en') (Line: 93)
Drupal\redirect\RedirectRepository->findMatchingRedirect('document/league-women-voters', Array, 'en') (Line: 109)
redirect_path_update(Array)'

The error doesn't happen 100% of the time on every node. But when it does, it is a WSOD and sometimes it appears that the document title does get changed, but there is no revision history and clearing the cache causes the change to revert.

🐛 Bug report

Status

Needs work

Version

1.7

Component

Code

Created by

🇺🇸United States nrackleff

Live updates comments and jobs are added and updated live.

Incomplete comments

Sign in to follow issues

Merge Requests

!92Redirect loop error when re-saving node with existing redirect
Open
🇺🇸United States jiong_ye
updated 9 months ago

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment over 1 year ago →
🇺🇸United States pookmish
Re-rolled the patch from #22 due to the 1.9 release
Open in Jenkins → Open on Drupal.org →
Core: 10.1.x + Environment: PHP 8.1 & MySQL 5.7
last update over 1 year ago
45 pass, 6 fail
Comment 9 months ago →
🇺🇸United States jiong_ye
attempt to fix Error: Class "Drupal\redirect\FormattableMarkup" not found in patch #22
Comment 9 months ago →
🇺🇸United States jiong_ye
Comment 9 months ago →
🇺🇸United States jiong_ye
fix logger
Merge request !92move patch file into issue fork → (Open) created by jiong_ye
Pipeline finished with Failed
9 months ago
Total: 243s
#137773
Comment 9 months ago →
🇨🇭Switzerland berdir Switzerland
There are 20 open issues with the word "loop" in them, for example 🐛 Redirect loop wrong detection (service unavailable: RedirectLoopException) Needs work , helping to identify duplicates, closing them and agreeing on the best solution between this and the other issue would be really helpful.
Comment 5 months ago →
🇺🇸United States pookmish
Re-rolling the patch to be used in composer.json patches for version 1.10. I'm not creating a MR since there seems to be a lack of clarity on the direction of the desired solution at this time.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024