- 🇺🇸United States bkosborne New Jersey, USA
Core issue is in. So I think this issue is just this:
That said, happy to keep this open and add redirect-specific test coverage as well that we can commit once the core issue is in.
Didn't notice this at first, due to having caching set to off for development. As soon as you turn page caching on though ... the lack of cache-control then means at least, Akamai won't cache the redirects.
https://www.drupal.org/project/drupal/issues/2527126#comment-10450329 →
https://www.drupal.org/project/drupal/issues/2573923#comment-10461121 →
With system.performance.cache.page.max_age = 0
$ curl -sIXGET http://development.local/node/1125
HTTP/1.1 301 Moved Permanently
Date: Wed, 28 Nov 2018 20:27:55 GMT
Server: Apache
X-Content-Type-Options: nosniff
X-Powered-By: PHP/7.2.10
Location: http://development.local/security
X-Drupal-Route-Normalizer: 1
X-UA-Compatible: IE=edge
Content-language: en
X-Content-Type-Options: nosniff
X-Frame-Options: SAMEORIGIN
X-Drupal-Cache-Tags: config:user.role.anonymous http_response node:1125
X-Drupal-Cache-Contexts: url.query_args:key user.permissions
Cache-Control: must-revalidate, no-cache, private
Expires: Sun, 19 Nov 1978 05:00:00 GMT
Vary:
X-Generator: Drupal 8 (https://www.drupal.org)
X-Drupal-Cache: MISS
Content-Length: 372
Content-Type: text/html; charset=UTF-8With system.performance.cache.page.max_age = 31536000
$ curl -sIXGET http://development.local/node/1125
HTTP/1.1 301 Moved Permanently
Date: Wed, 28 Nov 2018 20:17:14 GMT
Server: Apache
X-Content-Type-Options: nosniff
X-Powered-By: PHP/7.2.10
Location: http://development.local/security
X-Drupal-Route-Normalizer: 1
X-UA-Compatible: IE=edge
Content-language: en
X-Content-Type-Options: nosniff
X-Frame-Options: SAMEORIGIN
X-Drupal-Cache-Tags: config:user.role.anonymous http_response node:1125
X-Drupal-Cache-Contexts: url.query_args:key user.permissions
X-Generator: Drupal 8 (https://www.drupal.org)
X-Drupal-Cache: HIT
Content-Length: 372
Content-Type: text/html; charset=UTF-8I'll assume the issue is per those "CacheableResponseInterface" comments in the tickets?
Active
1.0
Code
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
Core issue is in. So I think this issue is just this:
That said, happy to keep this open and add redirect-specific test coverage as well that we can commit once the core issue is in.