Group dragging feature lost in 8.x-1.2

Created on 9 November 2018, over 6 years ago
Updated 7 August 2024, 8 months ago

In 8.x-1.0 there was a VERY useful feature: if you dragged the cross thingy to the right, the current item would "stick" to the previous one and go with it wherever you drag the latter. It allowed you to build a "chain" of items and then move them all in sequence to another place in the whole list. After I upgraded to 8.x-1.2 it doesn't work for me anymore. Am I missing something obvious? I don't believe it was even documented anywhere, I just discovered it by sheer chance and used it extensively ever since (until now, that is).

🐛 Bug report
Status

Fixed

Version

2.1

Component

Code

Created by

🇷🇺Russia marassa Moscow

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • @rang501 opened merge request.
  • 🇪🇪Estonia rang501 Viljandi

    Created issue fork and fixed the patch so it applies to 2.1.x.

  • 🇪🇪Estonia rang501 Viljandi

    I did add changes to make this work with Claro theme in Drupal 10. The structure was not preserved when dragging rows around and it did cause some weird issues where relationships were lost.

  • Status changed to Needs review over 1 year ago
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.4 & MySQL 8
    last update over 1 year ago
    1 pass
  • 🇪🇪Estonia rang501 Viljandi

    I saw some changes that were done here were added by the 🐛 Not working with Group By feature RTBC . I modified the code so this will apply with the latest patch from that issue.
    At the moment this will fix

    • Hierarchy functionality - it is broken in the Claro theme, it needs one header class, and rendering the indentation part was not correct, it did remove the SVG and there were no visible parent-child relationship lines available
    • custom entities (at the moment it expects 'nid' as entity id key, but others have 'id' usually)

    I did test this and did not find any weird behavior related to moving things around. Previously it messed things up, ordering was wrong, indentation incorrect, and was lost.

    Hopefully, someone can take a look at this with the other issue and see if it is possible to merge these things to a new release.

  • 🇪🇪Estonia rang501 Viljandi
  • Status changed to Fixed 8 months ago
  • 🇷🇺Russia marassa Moscow

    The hierarchy setting introduced in #2867348 and committed to 2.1.4 seems to have solved the problem - all that's needed is tick the Enable hierarchy box in the Draggableviews field settiings. Can be closed I guess.

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024