- Merge request !479Issue #3011966 by tomtech, introfini, bojanz, jeff veit, czigor, steveoliver,... → (Merged) created by TomTech
- 🇺🇸United States TomTech
MR created that implements two field formatters for adjustments.
One is separator based. The other displays as a table.
Configuration options include specifying the adjustment type(s) to include, whether to display the label(s) of the adjustments, and currency options.
We can consider the collectAdjustments as a followup enhancement.
- 🇮🇱Israel jsacksick
Thank you Tom for addressing this, retitling the issue.
Tested this manually, works great! Only one minor comment regarding the Adjustment types setting. Just wondering whether we should use the label simply? Or if we stick with the plural label, perhaps we should uppercase the first character using ucfirst?
I think everywhere else (e.g: when adding an adjustment from the order edit form) we simply use the label (which is singular).
-
jsacksick →
committed ac36aed6 on 3.x authored by
tomtech →
Issue #3011966 by tomtech, introfini, jsacksick, bojanz, jeff veit,...
-
jsacksick →
committed ac36aed6 on 3.x authored by
tomtech →
- 🇮🇱Israel jsacksick
Ok, went with the label for consistency. We might need a followup to call
collectAdjustments()
as it looks kinda odd to only display order level adjustments (which normally only contains shipping, shipping taxes and eventually shipping promotions). Other than that, all other adjustments are added to order items.
But I'm fine with doing this as a followup, since this is already a big improvement as we don't have formatters for anything atm :).