Slug is not displayed when option 'Hide slug if no ad is served' is selected

Created on 6 November 2018, about 6 years ago
Updated 18 October 2023, about 1 year ago

When option Hide slug if no ad is served is selected, slug is not displayed on front end even the ad is served.


(under Global Display Option (Global settings tab))

Slug is displayed only if option is not selected.

Proposed solution: Add option to control where slug will be displayed

  • (1) inside or
  • (2) outside

the ad container.

Default value: Slug is placed inside the ad container (existing functionality, option 1), no updates required after module update in case exiting settings need to remain.

Additional note: When method refresh() is called, slug which is placed inside the container (option (1)) will be removed too (this is existing functionality).

✨ Feature request
Status

Needs work

Version

1.0

Component

Code

Created by

πŸ‡¬πŸ‡§United Kingdom majda

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • πŸ‡ΊπŸ‡ΈUnited States mgaskey

    Re-rolling patch from #30 for 2.0.x branch. (There is no option to test with that branch though. Tested locally and patch applies.)

Production build 0.71.5 2024