- Open on Drupal.org βCore: 9.5.5 + Environment: PHP 7.3 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - last update
over 1 year ago Build Successful - last update
over 1 year ago Build Successful The last submitted patch, 3: votingapi_widgets-fix_ajax_in_views-3006463-3.patch, failed testing. View results β
- πΊπΈUnited States tr Cascadia
In the future please post an interdiff so we can see what you changed. I have attached that.
When can the request stack be NULL?
No one has reviewed this yet. Would it be possible for you to write a test that demonstrates the problem so we can verify the fix? This module has a serious lack of test cases, so every little bit helps to keep things working as intended and helps in early detection of problems caused by changes to Drupal core, PHP version, etc. Likewise, having at least one test allows patches like yours to be tested automatically - the "Build successful" and "Waiting for branch to pass" messages are a direct result of this module having no test cases. When we have no test cases and no one else confirming a problem or confirming a fix, then I lean towards being cautions and not committing so as not to potentially break existing sites.
- Status changed to Needs work
over 1 year ago 8:03pm 3 June 2023