Timezone offset not formatted correctly in .ics file

Created on 5 October 2018, over 5 years ago
Updated 3 May 2024, about 2 months ago

When I download a .ics file and then re-upload it into the validator at https://icalendar.org/validator.html it gives errors. It looks like these are because there are fields like "TZOFFSETFROM:-600" which should be "TZOFFSETFROM:-0600".

I have a patch I will attach below.

πŸ› Bug report
Status

Needs work

Version

3.0

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States rgristroph

Live updates comments and jobs are added and updated live.
  • Needs tests

    The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • πŸ‡ΊπŸ‡ΈUnited States maskedjellybean Portland, OR

    Thank you for the patch. It fixed my issue importing into Outlook for Mac.

    If you want to replicate the problem, use the module without this patch and try to import into Outlook for Mac. You'll see an error. Apply this patch, make a change to the node, save and repeat. No error.

    If you don't have Outlook for Mac, you run a file generated by this module through the ICS validator:

    https://icalendar.org/validator.html

    You'll see errors like "Invalid TZOFFSETFROM".

    Apply the patch, make a change to the node, save, download the file again and run it through the validator. You won't see that error anymore.

Production build 0.69.0 2024