Contrib.social

Navigating back in browser doesn't update view with Ajax facets

Open on Drupal.org →
Created on 5 September 2018, over 6 years ago
Updated 11 September 2023, over 1 year ago

Currently navigating back in the browser reloads the whole page, so we can get the correct filters & view again. This however only works on the first backward navigation, since the addEventListener for popstate is added in the click event.

So flow is as follows:
1. user clicks a few filters, url is updated accordingly, and window.addEventListener("popstate", function (e) {} is executed (since it is executed in the click handler).
2. User presses back, and browser reloads. No event listener is attached anymore.
3. User presses back again; view is not updated anymore since page doesn't reload anymore.

I propose we move the event listener outside of the click handler.

🐛 Bug report
Status

Needs work

Version

1.0

Component

Code

Created by

🇧🇪Belgium sam.spinoy@gmail.com

Live updates comments and jobs are added and updated live.
  • Needs tests

    The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • First commit to issue fork.
  • Comment about 1 year ago →
    🇺🇸United States jrb Raleigh-Durham Area, NC, USA

    Here's an update to the patch in #4 with the code that adds the event listener wrapped in a once() call so it doesn't get added multiple times (per the suggestion in #9).

  • Comment 10 months ago →
    🇬🇧United Kingdom fonant

    Patch in #12 works nicely here to fix the problems with facet selections and the browser's Back button. Thanks!

  • Status changed to Closed: won't fix 19 days ago
  • Comment 19 days ago →
    🇧🇪Belgium borisson_ Mechelen, 🇧🇪

    Since this is only for the ajax behavior of the regular blocks, and we are currently only supporting ajax-like behavior through facets 3.x, I'm going to close this as won't fix.

    The current suggestion is to try using views' ajax handling with facets 3.x for this.

    It could be that this is also a bug on core views, but that would need a core issue to fix.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024