There is ambiguity on whether existing permissions should be revoked or copied. Because the H5P module in modern use should be mostly be fresh installs, there isn't a lot of value to including the update hook (it should never really run, at this stage), and there are some downsides to doing so anyway.
I'll apply the patch to the 2.0.x branch for inclusion in the upcoming release.
- Merge request !43Applied permission naming change for H5P Editor permissions. → (Merged) created by msandoval
- 🇺🇸United States illeace
I've reviewed the code changes and tested before and after behavior on a D11 site. Everything looks good from my perspective. As discussed above, anyone who has been using alpha builds and has a role with this permission will lose the permission after updating and will need to re-add the renamed permission. We need to be sure the release notes for the next release include documentation about the change.
- First commit to issue fork.
-
sim_1 →
committed f31e879b on 2.0.x authored by
msandoval →
[#2988056] feat: Permission Naming too generic By: paalj By: frob By:...
-
sim_1 →
committed f31e879b on 2.0.x authored by
msandoval →
Now that this issue is closed, please review the contribution record.
As a contributor, attribute any organization helped you, or if you volunteered your own time.
Maintainers, please credit people who helped resolve this issue.