Don't clear all caches

Created on 16 July 2018, over 6 years ago
Updated 30 April 2023, over 1 year ago

After updating the node_access table by calling node_access_acquire_grants, this module also calls cache_clear_all();. On large sites, this causes an enormous performance hit. In my opinion, the cache should not be cleared.

I understand that some users expect to have caching, and yet see their changes immediately. Maybe this should be made optional?

If a cache clear must still happen, a more elegant approach might be to clear only the page cache, or target the cache_page table to remove only those URIs that refer to the updated nodes. But I don't think Flexi Access should concern itself with caching. That's better handled with other modules.

πŸ› Bug report
Status

Needs review

Version

1.0

Component

Code

Created by

πŸ‡ΏπŸ‡¦South Africa rudolfbyker South Africa

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.71.5 2024