Cannot set basic auth on a path with a wildcard

Created on 11 July 2018, over 6 years ago
Updated 5 November 2024, 29 days ago

Having an issue where I'm trying to use basic auth on this path `/export/orders/%`. The path does not require basic auth if I pass an argument in place of the wildcard

🐛 Bug report
Status

Needs work

Version

1.0

Component

Code

Created by

🇨🇦Canada dylf

Live updates comments and jobs are added and updated live.
  • Needs tests

    The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

    • roderik committed 0735b13f on 7.x-1.x
      Issue #2985210 by roderik, mr.baileys, dylf: Set basic auth on a path...
  • 🇳🇱Netherlands roderik Amsterdam,NL / Budapest,HU

    Thank you. the issue been committed.

    I added a different patch than #3:

    • basic_auth_path_matches_current() is replaced by a function that resolves to the menu path, using menu items instead of the path.
    • the 'return TRUE' just below this line has been replaced by a menu access check that occurred later in the code, because... basically that seemed better. (Though the first bullet point on its own is the significant thing.)

    I discussed the patch outside of this queue, because - well, please see the release notes .

    Then,

    • in the process, I somehow was made maintainer of this module.
    • unfortunately there was a three year delay / I forgot about things.

    To repeat my previous message: patch #3 can/should be discussed in #3063585: path is not registered in system. instead.

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024