Issue credit form looks to non-maintainers like they could do something with it but they in fact can't

Created on 7 June 2018, over 6 years ago
Updated 18 May 2024, 6 months ago

Problem/Motivation

I don't think I've ever viewed the issue credit UI as a non-maintainer prior to working on #2810485: Allow more maintainers to grant credit β†’ but I was hugely confused when I did.

Here's what a maintainer sees:

Here's what a non-maintainer sees:

Do you, like me, see absolutely no difference? There's one tiny (and I do mean tiny :)) one:

And... that's it. Otherwise, this field appears to work just fine, right up into telling you the issue updated successfully. It's just that your data changes aren't actually saved:

Proposed resolution

Something a lot more explicit. I'm guessing the entire form is visible right now because there's value in non-maintainers seeing the list and how it's checked so they can point out errors/omissions in crediting. Which makes sense, especially until #2810485: Allow more maintainers to grant credit β†’ is fixed.

As a VERY MVP, we could just prepend different text like "Only project maintainers are allow to modify this field." But we could likely do a lot better than that, too.

User interface changes

Yes. Let's discuss.

Remaining tasks

TBD.

πŸ› Bug report
Status

Fixed

Version

3.0

Component

User interface

Created by

πŸ‡¨πŸ‡¦Canada webchick Vancouver πŸ‡¨πŸ‡¦

Live updates comments and jobs are added and updated live.
  • Needs usability review

    Used to alert the usability topic maintainer(s) that an issue significantly affects (or has the potential to affect) the usability of Drupal, and their signoff is needed. When adding this tag, make it easy to review the issue. Make sure the issue summary describes the problem and the proposed solution. Screenshots usually help a lot! To get sign-off on issues with the "Needs usability review" tag, post about them in the #ux channel on Drupal Slack, and/or attend a UX meeting to demo the patch and get direct feedback from designers/UX folks/product management on next steps. If an issue represents a significant new feature, UI change, or change to the general "user experience" of Drupal, use Needs product manager review instead. See the scope of responsibilities for product managers.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

    • drumm β†’ committed dee5d088 on 7.x-3.x
      Fix regression from #2978223, update commit message template for non-...
  • Status changed to Fixed 7 months ago
  • πŸ‡ΊπŸ‡ΈUnited States drumm NY, US

    I don’t think there is anything else to do here. I believe I left it open for final acceptance testing.

    I think the key part missing is seeing who has credit already and who is about to get credit, if I am returning to an issue that a maintainer has already commented on.

    This was done with the βœ“ to the left of the checkboxes.

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024