Check access in NewResultsCheck::checkAll()

Not sure anymore what I meant with “check access”. So maybe just this, make extra-sure that the saved search is enabled?

Probably more relevant: We should also check that the saved search’s owner still has permission to use saved searches. They might have either lost the necessary role, or the role might have lost the necessary permission. Reacting to the former directly should also be pretty straight-forward, actually, so let’s do that, too.
I also included test coverage for both cases.

Testing whether the saved search actually has the property values that the entity query is conditioned on can’t hurt, but really seems overcautious.

The last submitted patch, 3: 2972305-3--results_check_check_access.patch, failed testing. View results →

The last submitted patch, 5: 2972305-5--results_check_check_access.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Since we now switched the module to use GitLab CI (cf. 📌 Enable GitLab CI Fixed ), I now created an MR for the patch in #7, also resolving a merge conflict.

Merged.

Automatically closed - issue fixed for 2 weeks with no activity.