When updating the configuration form your password gets wiped.

Created on 7 May 2018, over 6 years ago
Updated 28 February 2024, 10 months ago

If you go in to update your Fedex configuration form and don't enter your password it gets set to "".

πŸ› Bug report
Status

Closed: duplicate

Version

1.0

Component

Code

Created by

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • πŸ‡ΊπŸ‡ΈUnited States drakythe

    Attempting to maintain the security considerations I offer this patch. If the password field is empty it loads up the callback object entity and if that entity is not new then we access the existing config and set the password field to what it already is in the database. If it was already empty no harm no foul, but if a password exists we don't lose it.

  • Assigned to TomTech
  • Status changed to Closed: duplicate 10 months ago
  • πŸ‡ΊπŸ‡ΈUnited States TomTech

    The issue stems from the PluginSelectWidget in commerce core.

    When a plugin edit configuration form is initially loaded, the configuration is properly passed to the plugin before the form process begins. (This is in the PluginSelectWidget ->formElement() method.)

    When the form is posted back, though, the configuration was not being passed to the plugin.

    A fix has been committed in [#33021571] that resolves this. This should be in the next commerce release.

    If you need it before then, you can apply the diff from that MR as a patch.

    Closing this out as (Duplicate), since the fix is in commerce core.

Production build 0.71.5 2024