Library Discovery Collector cache per domain

Created on 17 April 2018, about 6 years ago
Updated 31 May 2024, 27 days ago

This might seem a little bit odd but I came across a bug using the Config UI, domain_admin_ui (a fork of the original because the original was missing some fixes) and the Color module.

The UI module is working great. It's saving the forms, even the Color (theme) form, and creating the right css files. The problem rises when the css files are overwritten by the Color module using the hook_library_info_alter. This hook is cached per Drupal install. So when requesting a second domain with other Color options the wrong css files are delivered.

I could not find a config option like the render cache context so I did not know any other option that replace the LibraryDiscoveryCollector with a custom one that set a domain specific cache name.

I'm not sure where and if this patch should be in the config module but I think this is the best option. I would expect that you can remove the Config UI without loosing functionality so the patch should be in the config module.

πŸ“Œ Task
Status

Fixed

Version

1.0

Component

Code

Created by

πŸ‡³πŸ‡±Netherlands h3rj4n

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.69.0 2024