Permission Reorder terms in %vocabulary is failure

The reason this is failing is because if the user does not have the "reset" permission for either all vocabularies or the specific vocabulary being looked at, the core overview form does not add the tabledrag data into the form (core/modules/taxonomy/src/Form/OverviewTerms::buildForm 443-471.

I'm not sure how this should be resolved in the module, but a workaround is to grant users both the reorder and reset permissions if you want them to be able to use the drag and drop reordering.

hey, I faced this issue too.
If the user does not have permission to edit, but only to reorder the taxonomy it fails.
Action that is used to render drag and drop functionality and weight is reset all weights.
I'm applying patch for this extra check.

Can confirm that #11 works. (user only having order terms permission now sees the table drag features).

The last submitted patch, 11: 2958658-reorder-terms-10.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

The reset button was still visible if a user had reorder permissions but no reset permissions. The merge request fixes this.
(Added patch of MR11 for secure use in composer).

The last submitted patch, 15: 2958658-15-permission-reorder-terms-11.diff, failed testing. View results →

#9 fixed it for me

#9 did fix the issue BUT I don't want to give reset permission to most users, it will cause utter havoc on our system.

#15 passes manual testing, thank you.

As there are no pipelines running any more I've put this back to NR.

Thanks for taking a look at this longstanding issue. We have since added a Gitlab pipeline and would require this to run so that we can see if the tests pass. So the MR needs a rebase to the latest code base before it can go into review again. Setting to Needs work for that. Note for anyone who wants to take a look at this: Please do not merge, but rebase! There is good documentation on drupal.org on how to do this, if you are not sure. Thanks again.

darvanen → changed the visibility of the branch 2958658-permission-reorder-terms to hidden.

darvanen → changed the visibility of the branch 2958658-permission-reorder-terms to active.

Oh I didn't realise, I should have checked the home page, thanks for that, I've rebased.

Fixed the phpcs failure but this definitely needs work on tests, don't have time for that at the moment.