- ๐ฎ๐ณIndia er.garg.karan Chandigarh
Is this issue still being worked on? I am facing this issue too often.
- Status changed to Needs review
4 months ago 7:01am 29 July 2024 - ๐ฎ๐ณIndia vikramsaini1609
I have provided a setting in admin to enable and disabled to throw this error.
- ๐ฎ๐ณIndia er.garg.karan Chandigarh
Thanks @vikramsaini1609 for this patch.
It worked well for me.
- Status changed to Needs work
3 months ago 10:04pm 3 September 2024 - ๐จ๐ญSwitzerland berdir Switzerland
I don't get the setting. It's not an exception anymore, just a warning, and I think it's worth to always do that, don't see the benefit of hiding the fact that some provided translations couldn't be saved.
The second part of my review in #22 wasn't applied and tests weren't added either as I asked in back in #15.
- ๐ท๐ดRomania ioana apetri
ioana apetri โ made their first commit to this issueโs fork.
- Merge request !75A missing field should not cause an exception when trying to save a translation. โ (Merged) created by ioana apetri
- ๐ท๐ดRomania ioana apetri
Hello, I have provided the changes discussed in #24. Thanks
-
berdir โ
committed cd12beb4 on 8.x-1.x authored by
ioana apetri โ
Issue #2955555 by ioana apetri, stijnstroobants, maebug, bmcclure,...
-
berdir โ
committed cd12beb4 on 8.x-1.x authored by
ioana apetri โ
- ๐จ๐ญSwitzerland berdir Switzerland
Amazing, a test :)
Thanks, merged.
Automatically closed - issue fixed for 2 weeks with no activity.